detect the actual tar version present on the system #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnwamk
reviewed
Jan 27, 2022
scripts/unpack_benchmarks.sh
Outdated
| if [[ "$OSTYPE" == "darwin"* ]]; then | ||
| TARVER=`tar --version | head -n 1` | ||
| if [[ "$TARVER" =~ "tar (GNU tar)" ]]; then | ||
| tar --overwrite -xf $TAR_FILE |
There was a problem hiding this comment.
Per our discussion elsewhere, the --overwrite flag might be better left off so this script can be rerun. (That would also match the bsdtar behavior, which uses the -k Keep (don't overwrite) existing files flag.)
pnwamk
approved these changes
Jan 27, 2022
Ptival
force-pushed
the
vr/detect-actual-tar-version
branch
from
53223bf to
1158f3d
Compare
The current script does not work on my machine because it assumes that any machine running Darwin will also have bsdtar. I am running Darwin, but have also installed the superior GNU tar, so the assumption does not hold. Instead, I made it read the `--version` output to see if we identify either GNU or BSD version of tar.
Ptival
force-pushed
the
vr/detect-actual-tar-version
branch
from
1158f3d to
bfde034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current script does not work on my machine because it assumes that any
machine running Darwin will also have bsdtar. I am running Darwin, but have
also installed the superior GNU tar, so the assumption does not hold.
Instead, I made it read the
--versionoutput to see if we identify either GNUor BSD version of tar.