Fix some minor pretty-printing bugs #115
Conversation
The `name` of a `DILabel` is meant to be escaped in double quotes. Fixes #114.
As the LLVM source code indicates in https://github.com/llvm/llvm-project/blob/9841daf27076886c6ab8e155eb812bda76f77532/llvm/lib/AsmParser/LLParser.cpp#L5215, the intent was always to have `dicuRangesBaseAddress` be an optional field. This updates the `llvm-pretty` AST to reflect this. With this change, picking a default value of `Nothing` will cause `dicuRangesBaseAddress` not to be pretty-printed, which makes it easier to support pre-11 versions of LLVM (when `rangesBaseAddress` was introduced). Fixes #113.
|
The changes seem good to me, but I'm happy to re-review when this is marked ready :) |
|
For context: these are both issues that we ran into while trying to make the test case from GaloisInc/llvm-pretty-bc-parser#223 work on older LLVMs. I was hoping that these two commits would be enough to make that test case go through, but sadly, we uncovered yet another issue in #116, and fixing #116 is unlikely to be as straightforward. Considering that this PR does introduce a breaking API change, I'm inclined to park this until we know for sure that this approach will in fact fix GaloisInc/llvm-pretty-bc-parser#223, #116, and any related issues we encounter in the process. |
|
This PR fixes the issue by wrapping a field in a |
|
Superseded by #121. |
This:
DILabels in double quotes. This fixes Label targets are not represented correctly for llvm-as consumption #114.dicuRangesBaseAddress :: Maybe Booland omits pretty-printing it if is has the valueNothing. This fixesdicuRangesBaseAddressshould be aMaybe Boolinstead of aBoolto support old LLVMs #113.