Support metadata fields added in LLVM 14 #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langston-barrett
approved these changes
Apr 7, 2023
This lays the foundation towards an eventual fix for GaloisInc/llvm-pretty-bc-parser#85. GitHub commit: llvm/llvm-project@d5561e0 It's an unsigned int: https://github.com/llvm/llvm-project/blob/d5561e0a0bbd484da17d3b68ae5fedc0a057246b/llvm/include/llvm/IR/DebugInfoMetadata.h#L783 Co-authored-by: Ryan Scott <rscott@galois.com>
This paves the way for an eventual fix to GaloisInc/llvm-pretty-bc-parser#217.
This paves the way for an eventual fix for GaloisInc/llvm-pretty-bc-parser#188.
RyanGlScott
added a commit
to GaloisInc/crucible
that referenced
this pull request
Apr 20, 2023
This adds support for LLVM versions up to 14 by: * Bumping the `llvm-pretty` submodule to bring in the changes from GaloisInc/llvm-pretty#109. * Bumping the `llvm-pretty-bc-parser` submodule to bring in the changes from GaloisInc/llvm-pretty-bc-parser#219. * Updating the test output in `crux-llvm` and `uc-crux-llvm`'s test suites accordingly.
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Apr 20, 2023
This adds support for LLVM versions up to 14 by: * Bumping the `llvm-pretty` submodule to bring in the changes from GaloisInc/llvm-pretty#109. * Bumping the `llvm-pretty-bc-parser` submodule to bring in the changes from GaloisInc/llvm-pretty-bc-parser#219. * Bumping the `crucible` submodule to bring in the changes from GaloisInc/crucible#1083. * Updating the surrounding documentation accordingly.
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
May 26, 2023
This adds support for LLVM versions up to 14 by: * Bumping the `llvm-pretty` submodule to bring in the changes from GaloisInc/llvm-pretty#109. * Bumping the `llvm-pretty-bc-parser` submodule to bring in the changes from GaloisInc/llvm-pretty-bc-parser#219. * Bumping the `crucible` submodule to bring in the changes from GaloisInc/crucible#1083. * Updating the surrounding documentation accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this PR is to add support for
btf_tagannotations on LLVM's metadata nodes, which are necessary to load essentially any bitcode file compiled withclang-14 -g. See GaloisInc/llvm-pretty-bc-parser#188.This also adds support for DWARF address spaces in
DIDerivedType(see GaloisInc/llvm-pretty-bc-parser#85) and alignment inDILocalVariable(see GaloisInc/llvm-pretty-bc-parser#217), both of which appear immediately beforebtf_tagannotations in their respective metadata nodes. These do not occur as often asbtf_tagannotations do, but I added them for the sake of completeness.