BUGFIX: Let terms in CFG creation #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes what I suspect is a bug in how `Let` terms are translated to CFG nodes, where the bound name is inserted into the wrong node(s). Seems like a benign bug though -- I think `Let` terms are translated to `Do` terms somewhere upstream, because I wasn't able to reproduce the bug in practice, and I confirmed that this code is not executed when processing a test file containing `let` statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes what I suspect is a bug in how
Letterms are translated to CFG nodes, where the bound name is inserted into the wrong node(s).Seems like a benign bug though -- I think
Letterms are translated toDoterms somewhere upstream, because I wasn't able to reproduce the bug in practice, and I confirmed that this code is not executed when processing a test file containingletstatements.