Open
Conversation
Arusekk
commented
Apr 2, 2025
Arusekk
commented
Apr 2, 2025
peace-maker
requested changes
Jan 18, 2026
| return x | ||
|
|
||
|
|
||
| def hexstr(s, force=False): |
Member
There was a problem hiding this comment.
Can you add documentation and tests for this too please?
| " To remove the existing entry from your known_hosts and trust the new key, run the following commands:\n" | ||
| " $ ssh-keygen -R %(host)s\n" | ||
| " $ ssh-keygen -R [%(host)s]:%(port)s" % locals()) | ||
| " $ ssh-keygen -R {host}\n" |
Member
There was a problem hiding this comment.
I think this needs to be an f-string itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we require py3.6 we can use good things to our advantage. This PR aims to reduce code and make it readable with no functional change.