WIP: Add SCF Potential #751
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adivijaykumar
force-pushed
the
gegenbauer
branch
from
3c2ad34 to
f9dc960
Compare
|
Awesome! I am on the road ATM, but I can take a look at this soon. |
nstarman
reviewed
Oct 27, 2025
| Parameters | ||
| ---------- | ||
| t : `~galax.typing.BBtQuSz0` | ||
| t : `~galax._custom_types.BBtQuSz0` |
There was a problem hiding this comment.
True. We should fix this. Probably my just not having the types in the docstring. The actual annotations are authoritative 🤷 .
There was a problem hiding this comment.
For static analyses' sake we prefer the long-form exports. Annoying, I know, but it makes mypy happier.
| "wadler_lindig>=0.1.6", | ||
| "xmmutablemap>=0.1", | ||
| "zeroth>=1.0", | ||
| "spexial @ git+https://github.com/JAXtronomy/spexial.git@main", |
There was a problem hiding this comment.
unfortunately, spexial is unlikely to be released. Can you move the function into potential/scf/?
| "xmmutablemap>=0.1", | ||
| "zeroth>=1.0", | ||
| "spexial @ git+https://github.com/JAXtronomy/spexial.git@main", | ||
| "hypothesis>=6.135.14", |
There was a problem hiding this comment.
This is a test-time dependency. It can be added by uv add --group test hypothesis.
| "zeroth>=1.0", | ||
| "spexial @ git+https://github.com/JAXtronomy/spexial.git@main", | ||
| "hypothesis>=6.135.14", | ||
| "gala>=1.9.1", |
There was a problem hiding this comment.
Gala is already a test-time dependency. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Still being tested