feat: HarmonicOscillatorPotential #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstarman
force-pushed
the
pot-harmonic-oscillator
branch
2 times, most recently
from
ddc8d32
to
bc25ccb
Compare
nstarman
force-pushed
the
pot-harmonic-oscillator
branch
from
bc25ccb
to
7a288b1
Compare
nstarman
force-pushed
the
pot-harmonic-oscillator
branch
5 times, most recently
from
758791b
to
b7e7f65
Compare
adrn
reviewed
Aug 24, 2024
|
|
||
| """ | ||
|
|
||
| omega: AbstractParameter = ParameterField(dimensions="frequency") # type: ignore[assignment] |
There was a problem hiding this comment.
Allow frequency or angular frequency? Or only angular frequency?
There was a problem hiding this comment.
It would be great to offer many input options. On some classes I've starting building the .constructor method for this. Supporting alternative dimensions for parameters at initialization is a great use case for that. The constructed class always has the same fields with same dimensions, but there are a million ways to get there!
nstarman
force-pushed
the
pot-harmonic-oscillator
branch
7 times, most recently
from
7904050
to
465b613
Compare
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
nstarman
force-pushed
the
pot-harmonic-oscillator
branch
from
465b613
to
efb5cf8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
==========================================
+ Coverage 96.57% 96.59% +0.02%
==========================================
Files 76 76
Lines 3003 3028 +25
==========================================
+ Hits 2900 2925 +25
Misses 103 103 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.