Skip to content

Commit

Permalink
x86/mce: Mark mce_end() noinstr
Browse files Browse the repository at this point in the history
[ Upstream commit b481353 ]

It is called by the #MC handler which is noinstr.

Fixes

  vmlinux.o: warning: objtool: do_machine_check()+0xbd6: call to memset() leaves .noinstr.text section

Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/20211208111343.8130-9-bp@alien8.de
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
suryasaimadhu authored and gregkh committed Jan 27, 2022
1 parent f166c0b commit b26d3a8
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions arch/x86/kernel/cpu/mce/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1081,10 +1081,13 @@ static int mce_start(int *no_way_out)
* Synchronize between CPUs after main scanning loop.
* This invokes the bulk of the Monarch processing.
*/
static int mce_end(int order)
static noinstr int mce_end(int order)
{
int ret = -1;
u64 timeout = (u64)mca_cfg.monarch_timeout * NSEC_PER_USEC;
int ret = -1;

/* Allow instrumentation around external facilities. */
instrumentation_begin();

if (!timeout)
goto reset;
Expand Down Expand Up @@ -1128,7 +1131,8 @@ static int mce_end(int order)
/*
* Don't reset anything. That's done by the Monarch.
*/
return 0;
ret = 0;
goto out;
}

/*
Expand All @@ -1144,6 +1148,10 @@ static int mce_end(int order)
* Let others run again.
*/
atomic_set(&mce_executing, 0);

out:
instrumentation_end();

return ret;
}

Expand Down

0 comments on commit b26d3a8

Please sign in to comment.