Slaughter / Chopper Tech reborn support #454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parity with other farms* Is it WAI?
also generalize
Technici4n
suggested changes
May 21, 2022
|
Well, it defines getEnergyMaxOutput as 0, so extract() does nothing... (or is there any other reason?) |
|
Sounds like it would maybe make more sense to allow these items to extract energy? Instead of bypassing an implementation detail? |
|
Yes, I'll try making pr in tech reborn side |
nether tree
Patch 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows usage of energy based items
Those items can't extract energy, so it should use SimpleBatteryItem.tryUseEnergy()