-
-
Notifications
You must be signed in to change notification settings - Fork 0
Add a jumbotron to the home page. #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This commit adds a jumbotron to the home page to make it more welcoming to new users. It also includes the necessary CSS styling for the jumbotron. In addition, it fixes the application by installing all the required dependencies and updating the code to be compatible with the latest version of Flask-Babel.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR introduces a styled jumbotron section on the home page by adding new CSS rules and HTML markup, and ensures the application runs with updated dependencies by installing missing packages and adjusting Flask-Babel initialization for compatibility. Class diagram for updated Flask-Babel integrationclassDiagram
class Babel {
+init_app(app)
+localeselector(func)
}
class FlaskApp {
+run()
+config
+routes
}
FlaskApp --> Babel : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @GYFX35 - I've reviewed your changes - here's some feedback:
- Wrap the jumbotron title and description in translation functions (e.g.
_()) so they’re i18n-ready. - Consider conditionally rendering the static jumbotron versus the personalized greeting for authenticated users to avoid losing the user’s name on the home page.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Wrap the jumbotron title and description in translation functions (e.g. `_()`) so they’re i18n-ready.
- Consider conditionally rendering the static jumbotron versus the personalized greeting for authenticated users to avoid losing the user’s name on the home page.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This commit adds a jumbotron to the home page to make it more welcoming to new users. It also includes the necessary CSS styling for the jumbotron. In addition, it fixes the application by installing all the required dependencies and updating the code to be compatible with the latest version of Flask-Babel.
Summary by Sourcery
Add a welcoming jumbotron to the home page and ensure the application runs by installing required dependencies and updating Flask-Babel compatibility
New Features:
Bug Fixes:
Enhancements: