Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fewer allocations and more performant functions in runcircuit #304

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use fewer allocations and more performant functions in runcircuit #304

wants to merge 2 commits into from

Commits on Aug 2, 2023

  1. Use fewer allocations and more performant functions in runcircuit 

    * Use `isodd`. It is more readable and more performant
* Avoid allocations in a few places

It's good practice to habitually code this way because:
* The code is more concise, clean, and readable.
* In cases where this is a bottleneck (probably not here) the increase in performance is very significant.
* The code serves as model for future development so that the benefits above accrue.
    @jlapeyre
    jlapeyre committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    f8fca68 View commit details
    Browse the repository at this point in the history

  2. Fix spelling errors in README.md 

    Note: If the lines were wrapped. Or written one sentence per line, etc.,
the edits and diffs to the README would be easier to read. (But I think
GH will highlight changed characters)
    @jlapeyre
    jlapeyre committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    789f85b View commit details
    Browse the repository at this point in the history