Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring GT++ 2025-02-13 #3948

Merged
merged 12 commits into from
Feb 16, 2025
Merged

Refactoring GT++ 2025-02-13 #3948

merged 12 commits into from
Feb 16, 2025

Conversation

serenibyss
Copy link
Member

@serenibyss serenibyss commented Feb 13, 2025

Previous PRs:

Remove some util classes that are not needed and are easy to remove.

Also removes a few configs which resulted in some dead code since they were not modified in the modpack repo, and they have no benefit to be kept if we don't change them ourselves

@serenibyss serenibyss requested a review from a team February 13, 2025 21:13
@serenibyss serenibyss added the refactor For PRs rewritting a part of the code to have a nicer code overall. label Feb 13, 2025
@serenibyss serenibyss changed the title GT++ utils cleanup Refactoring GT++ 2025-02-13 Feb 13, 2025
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Feb 14, 2025
Copy link
Contributor

@YannickMG YannickMG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"11 commits to review", but 5 of the commits are these:
image

@Dream-Master Dream-Master enabled auto-merge (squash) February 16, 2025 15:06
@Dream-Master Dream-Master merged commit d75aad9 into master Feb 16, 2025
5 checks passed
@Dream-Master Dream-Master deleted the gtpp-utils-cleanup branch February 16, 2025 15:14
@Dream-Master Dream-Master removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor For PRs rewritting a part of the code to have a nicer code overall.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants