Remove SPOOKY from Biome Humidity List #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crops++ would make
SPOOKY
type biomes very humid, which would break the common sense in most of those biomes.Here's the list of the related biomes.
In IC2, the crops humid calculating would use code like this
So it would always use the highest humidity value inside the biome type list.
For keyword
SPOOKY
, the humid bonus was set to 7 in crops++, and this is not good at all.Related biomes:
Nether Biome or Wasteland,
NETHER(-10)
,WASTELAND(-5)
,SANDY(-5)
andSPARSE(-5)
are all considered to be a dry keyword. Due to the IC2 algorithm,SPOOKY(7)
would win, and make it out a humid environment.Galaxy Space related Biomes:
These biomes all have keywords as
COLD(-5)
,DRY(-10)
andDEAD(-5)
, so they should all be considered to be dry. Due to the IC2 algorithm,SPOOKY(7)
would win, and make it out a humid environment.Data are actually coming from https://github.com/cubic-chariot/ic2crops/blob/master/src/BiomeData.ts