Update Juno SDK files #42
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Disclaimer: This comment was AI-generated and is not necessarily completely accurate. Please take code comments with a grain of salt.
PR Summary
This PR standardizes formatting across the Juno SDK codebase, focusing on consistent indentation, spacing, and quote styles.
- Modified all API and model files with consistent 4-space indentation instead of 2-space indentation
- Changed attribute type maps to use double quotes instead of single quotes throughout model files
- Consolidated multi-line imports into more compact single-line imports in API files
- Removed
ProjectResponsesexport and import frommodels.tswhich could potentially break dependent code - Added consistent blank lines at the end of files for better git compatibility
PR Checklist ✅
General
- ❌ Avoids unused imports, variables, or functions - The removal of
ProjectResponsesfrom models.ts could break dependent code
Your PR score is 95/100. The formatting changes are well-executed and consistent, but the removal of ProjectResponses should be verified to ensure it doesn't break existing functionality.
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
44 file(s) reviewed, 20 comment(s)
Edit PR Review Bot Settings | Greptile
| } | ||
| } else { | ||
| if (basePathOrUsername) { | ||
| this.basePath = basePathOrUsername |
There was a problem hiding this comment.
syntax: Missing semicolon at the end of this line
| this.basePath = basePathOrUsername | |
| this.basePath = basePathOrUsername; |
| } | ||
| } else { | ||
| if (basePathOrUsername) { | ||
| this.basePath = basePathOrUsername |
There was a problem hiding this comment.
syntax: Missing semicolon at the end of this line
| this.basePath = basePathOrUsername | |
| this.basePath = basePathOrUsername; |
| this.basePath = basePathOrUsername | ||
| } |
There was a problem hiding this comment.
syntax: Missing semicolon at the end of this line
| 'API_Key': new HttpBearerAuth(), | ||
| } |
There was a problem hiding this comment.
syntax: Missing semicolon after object declaration
| let authenticationPromise = Promise.resolve(); | ||
| authenticationPromise = authenticationPromise.then(() => this.authentications.default.applyToRequest(localVarRequestOptions)); | ||
|
|
There was a problem hiding this comment.
logic: Authentication is only applying the default auth, but not checking if API_Key.accessToken exists like in other API files (e.g., authApi.ts)
| export enum TypeEnum { | ||
| _0 = <any> '0', | ||
| _1 = <any> '1', | ||
| _12 = <any> '-1' |
There was a problem hiding this comment.
style: The enum value '_12' is named inconsistently with its value '-1'. Consider renaming to '_MINUS_1' for clarity and consistency with other model files like userResponse.ts.
| "name": "data", | ||
| "baseName": "data", | ||
| "type": "string" | ||
| } ]; |
There was a problem hiding this comment.
style: The closing bracket of the array is on the same line as the last object entry, which is inconsistent with the opening bracket style on line 23. Consider moving it to a new line for better readability.
| "name": "dkim2", | ||
| "baseName": "dkim2", | ||
| "type": "SendGridDNSRecord" | ||
| } ]; |
There was a problem hiding this comment.
style: There's an extra closing bracket ']' at the end of this line that should be on its own line for better readability.
| static attributeTypeMap: Array<{name: string, baseName: string, type: string}> = [ | ||
| { | ||
| "name": "mailCname", | ||
| "baseName": "mail_cname", | ||
| "type": "SendGridDNSRecord" | ||
| }, | ||
| { | ||
| "name": "dkim1", | ||
| "baseName": "dkim1", | ||
| "type": "SendGridDNSRecord" | ||
| }, | ||
| { | ||
| "name": "dkim2", | ||
| "baseName": "dkim2", | ||
| "type": "SendGridDNSRecord" | ||
| } ]; |
There was a problem hiding this comment.
style: The formatting of this array is inconsistent with TypeScript best practices. Consider using consistent quotes (either single or double) throughout the codebase.
| "name": "projectIds", | ||
| "baseName": "projectIds", | ||
| "type": "Array<number>" | ||
| } ]; |
There was a problem hiding this comment.
style: There's an extra closing bracket at the end of line 64 that's attached to the array declaration without proper spacing. This should be on a new line for better readability.
Update Juno SDK files