fix(web): wrap Explorer with GraphProvider - #540
Merged
Conversation
DependencyList (and other graph-context consumers rendered inside
Explorer) call useGraphContext(), but Explorer never rendered a
<GraphProvider> wrapper — the comment at line 52 incorrectly assumed
one was already present higher in the tree. This crashed the
Dependencies tab with 'useGraphContext must be used within a
<GraphProvider>' as soon as the web dashboard was actually run.
Fixed by wrapping Explorer's return JSX with <GraphProvider
repoUrl={repoUrl} branch={branch}>.
ThreatCrush Security Scan11 finding(s) MEDIUM: 4 | LOW: 7
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DependencyList (and other graph-context consumers rendered inside Explorer) call useGraphContext(), but Explorer never rendered a wrapper — the comment at line 52 incorrectly assumed one was already present higher in the tree. This crashed the Dependencies tab with 'useGraphContext must be used within a ' as soon as the web dashboard was actually run. Fixed by wrapping Explorer's return JSX with .
What changed
How was this verified
Checklist
npx tsc --noEmit -p apps/web/tsconfig.json(if touching apps/web)playground/(if touching parser/detector/pipeline)grep/cat)progres/PROGRES-*.mdfile with a dated entry (## YYYY-MM-DD — title)scripts/log-progress.shinstead of hand-editing PROGRES files, where applicableemptyfiles introduced (check via the empty-file scan inPROGRES.md)