issue-250-ridge-transforms

[Hojat-Shirmard]

Search for "hjt" in the file; you'll see I've added lines of code in four different places.

[michaelchin]

@Hojat-Shirmard

• I have changed the title to "issue-250-ridge-transforms". It is more descriptive.
• Can you move the two functions to the end of the file and fix the indentation?
• let's add "ridge_transforms" as property(return self.ridges + self.transforms), similar to this

  gplately/gplately/plot.py

  Lines 383 to 387 in bea66aa

  	@property
  	def topological_plate_boundaries(self):
  	if self._topological_plate_boundaries is None:
  	self.update_time(self.time)
  	return self._topological_plate_boundaries

• create a test program, similar to https://github.com/GPlates/gplately/blob/issue-250-ridge-transforms/tests-dir/unittest/test_plot_with_raster.py (remove the parts which you don't need.)

[Hojat-Shirmard]

Hi @michaelchin
I made a second commit considering your requested changes. To test the code, should I add plot.plot.ridge_transforms to the code you shared and run it in the Jupyter notebook?

[michaelchin]

Hi @michaelchin I made a second commit considering your requested changes. To test the code, should I add plot.plot.ridge_transforms to the code you shared and run it in the Jupyter notebook?

yes, add plot_ridge_transform() funciton call and comment out other plotting code to see the result more clearly.

And you can see your code changes here https://github.com/GPlates/gplately/pull/298/files. there are still errors in the code changes.

[Hojat-Shirmard]

How can I know where the errors are?

[michaelchin]

How can I know where the errors are?

Have you tried to click this link https://github.com/GPlates/gplately/pull/298/files?

if you did, see the screenshot below for example.

You need to make sure the changes are intended. And only make changes when it is necessary.

[Hojat-Shirmard]

I reckon I need to create a new environment in Anaconda and install my modified branch to check if it’s working properly, right?
I've also passed some courses on YouTube and learned a bit about Docker, so if there are any instructions or steps to follow with Docker, I’d be happy to try that as well.