Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling conformance_tests on Mac #66

Closed
wants to merge 1 commit into from

Conversation

dubik
Copy link

@dubik dubik commented Jul 25, 2016

CLWPlatform doesn't enumerate Mac's CPU as OpenCL device because
Mac OS doesn't allow creation of work group with 1+ devices if CPU
is there as well.

CLWPlatform doesn't enumerate Mac's CPU as OpenCL device because
Mac OS doesn't allow creation of work group with 1+ devices if CPU
is there as well.
@yozhijk
Copy link
Contributor

yozhijk commented Jul 27, 2016

Hi @dubik ,

There are several test in conformance suite which do not require OpenCL CPU device, but testing versus brutforce instead. Could you disable only the tests explicitly using CPU CL device?

@dubik
Copy link
Author

dubik commented Jul 27, 2016

Sorry, didn't notice them. Do you mind if I extract them into own class? Otherwise I would need to apply some macro magic to prepend those test cases name with "DISABLED_" only on mac.

@yozhijk
Copy link
Contributor

yozhijk commented Jul 27, 2016

@dubik , feel free to split it into gpu-vs-brutforce and clgpu-vs-clcpu parts, no problem

@dubik
Copy link
Author

dubik commented Jul 27, 2016

Hm, I checked conformance suite few times and I couldn't find tests which would not use apicpu_. Am I missing something?

@yozhijk
Copy link
Contributor

yozhijk commented Aug 1, 2016

Hi @dubik ,

Sorry for delay, was busy with Siggraph stuff. Yes, I should have been more specific: all the _Bruteforce test are currently testing both cpu and gpu devices vs bruteforce, feel free to remove cpu from them.

Thanks,
-Dmitry

@DeanoC
Copy link
Contributor

DeanoC commented Aug 1, 2016

There are refactored unit tests in the vulkan branch at the moment. That
tests both CL GPU and CPU seperately against the bruteforce tests. Should
be easy to only test CL GPU on Mac

Deano

On 1 August 2016 at 11:33, Dmitry Kozlov notifications@github.com wrote:

Hi @dubik https://github.com/dubik ,

Sorry for delay, was busy with Siggraph stuff. Yes, I should have been
more specific: all the _Bruteforce test are currently testing both cpu and
gpu devices vs bruteforce, feel free to remove cpu from them.

Thanks,
-Dmitry


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#66 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA46C595IE3MU7R5ZP-hx3qCHbto8QQWks5qbb1mgaJpZM4JT1d-
.

@dubik
Copy link
Author

dubik commented Aug 1, 2016

Ok, I will do it at vulkan branch then.

@DeanoC
Copy link
Contributor

DeanoC commented Aug 1, 2016

@dubik I'm in that file right now so I'll make sure CPU OpenCL tests are off on mac on vulkan branch :)

@dubik
Copy link
Author

dubik commented Aug 1, 2016

@DeanoC Ah, cool I close the request then.

@dubik dubik closed this Aug 1, 2016
DeanoC added a commit that referenced this pull request Aug 1, 2016
The unit tests have changed enough on the Vulkan branch that the pull
request wouldn't work as is but this does the same kind of thing (and as
a bonus keeps the Mac GPU conformance test which is nice)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants