-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling conformance_tests on Mac #66
Conversation
CLWPlatform doesn't enumerate Mac's CPU as OpenCL device because Mac OS doesn't allow creation of work group with 1+ devices if CPU is there as well.
Hi @dubik , There are several test in conformance suite which do not require OpenCL CPU device, but testing versus brutforce instead. Could you disable only the tests explicitly using CPU CL device? |
Sorry, didn't notice them. Do you mind if I extract them into own class? Otherwise I would need to apply some macro magic to prepend those test cases name with "DISABLED_" only on mac. |
@dubik , feel free to split it into gpu-vs-brutforce and clgpu-vs-clcpu parts, no problem |
Hm, I checked conformance suite few times and I couldn't find tests which would not use apicpu_. Am I missing something? |
Hi @dubik , Sorry for delay, was busy with Siggraph stuff. Yes, I should have been more specific: all the _Bruteforce test are currently testing both cpu and gpu devices vs bruteforce, feel free to remove cpu from them. Thanks, |
There are refactored unit tests in the vulkan branch at the moment. That Deano On 1 August 2016 at 11:33, Dmitry Kozlov notifications@github.com wrote:
|
Ok, I will do it at vulkan branch then. |
@dubik I'm in that file right now so I'll make sure CPU OpenCL tests are off on mac on vulkan branch :) |
@DeanoC Ah, cool I close the request then. |
The unit tests have changed enough on the Vulkan branch that the pull request wouldn't work as is but this does the same kind of thing (and as a bonus keeps the Mac GPU conformance test which is nice)
CLWPlatform doesn't enumerate Mac's CPU as OpenCL device because
Mac OS doesn't allow creation of work group with 1+ devices if CPU
is there as well.