Clearing up some TODOs

GPUOpen-LibrariesAndSDKs · Jan 22, 2018 · ff39614 · ff39614
1 parent 81d8dc0
commit ff39614
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/RadeonRays/src/accelerator/bvh2.h b/RadeonRays/src/accelerator/bvh2.h
@@ -199,7 +199,7 @@ namespace RadeonRays
         std::size_t num_items = 0;
         for (auto iter = begin; iter != end; ++iter)
         {
-            // TODO: how to deal with quads? create 2 trianles?? (gboisse)
+            // Quads are deprecated and no longer supported
             assert(static_cast<const Mesh *>(*iter)->puretriangle());
             num_items += static_cast<const Mesh *>(*iter)->num_faces();
         }

diff --git a/RadeonRays/src/intersector/intersector_lds.cpp b/RadeonRays/src/intersector/intersector_lds.cpp
@@ -113,7 +113,7 @@ namespace RadeonRays
         }
         else
         {
-            // TODO: implement (gboisse)
+            // TODO: implement vulkan kernels (gboisse)
             assert(device->GetPlatform() == Calc::Platform::kVulkan);
             m_gpuData->bvh_prog.executable = m_device->CompileExecutable("../RadeonRays/src/kernels/GLSL/bvh2.comp", nullptr, 0, buildopts.c_str());
             m_gpuData->qbvh_prog.executable = m_device->CompileExecutable("../RadeonRays/src/kernels/GLSL/bvh2_fp16.comp", nullptr, 0, buildopts.c_str());
@@ -129,7 +129,7 @@ namespace RadeonRays
 #if USE_VULKAN
         if (device->GetPlatform() == Calc::Platform::kVulkan)
         {
-            // TODO: implement (gboisse)
+            // TODO: implement vulkan kernels (gboisse)
             if (m_gpudata->bvh_prog.executable == nullptr)
                 m_gpuData->executable = m_device->CompileExecutable(g_bvh2_vulkan, std::strlen(g_bvh2_vulkan), buildopts.c_str());
             if (m_gpuData->qbvh_prog.executable == nullptr)

diff --git a/RadeonRays/src/kernels/CL/intersect_bvh2_lds.cl b/RadeonRays/src/kernels/CL/intersect_bvh2_lds.cl
@@ -39,8 +39,6 @@ TYPE DEFINITIONS
 // BVH node
 typedef struct
 {
-    // TODO: add explanatory comment (gboisse)
-
     float4 aabb_left_min_or_v0_and_addr_left;
     float4 aabb_left_max_or_v1_and_mesh_id;
     float4 aabb_right_min_or_v2_and_addr_right;

diff --git a/RadeonRays/src/kernels/CL/intersect_bvh2_lds_fp16.cl b/RadeonRays/src/kernels/CL/intersect_bvh2_lds_fp16.cl
@@ -41,8 +41,6 @@ TYPE DEFINITIONS
 // BVH node
 typedef struct
 {
-    // TODO: add explanatory comment (gboisse)
-
     uint4 aabb01_min_or_v0_and_addr0;
     uint4 aabb01_max_or_v1_and_addr1_or_mesh_id;
     uint4 aabb23_min_or_v2_and_addr2_or_prim_id;