Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update macos release to Qt 6.5.3 #1284

Merged
merged 1 commit into from
Jun 5, 2024
Merged

update macos release to Qt 6.5.3 #1284

merged 1 commit into from
Jun 5, 2024

Conversation

tsteven4
Copy link
Collaborator

@tsteven4 tsteven4 commented Jun 5, 2024

This avoids warnings for our release build on macos with Qt 6.2.4 like:

CMake Warning at /Users/runner/Cache/Qt/6.2.4/macos/lib/cmake/Qt6/FindWrapOpenGL.cmake:41 (target_link_libraries):
-- Generating done (0.0s)
  Target "gpsbabelfe" requests linking to directory
-- Build files have been written to: /Users/runner/work/gpsbabel/gpsbabel
  "/Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/System/Library/Frameworks".
  Targets may link only to libraries.  CMake is dropping the item.
Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.29.3/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
  /Users/runner/Cache/Qt/6.2.4/macos/lib/cmake/Qt6Gui/Qt6GuiDependencies.cmake:48 (find_dependency)
  /Users/runner/Cache/Qt/6.2.4/macos/lib/cmake/Qt6Gui/Qt6GuiConfig.cmake:40 (include)
  /Users/runner/Cache/Qt/6.2.4/macos/lib/cmake/Qt6/Qt6Config.cmake:209 (find_package)
  gui/CMakeLists.txt:25 (find_package)

Copy link

codacy-production bot commented Jun 5, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ed07a18) 27614 17205 62.31%
Head commit (ef3e932) 55237 (+27623) 34419 (+17214) 62.31% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1284) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@tsteven4
Copy link
Collaborator Author

tsteven4 commented Jun 5, 2024

NOTE: This raises drops macOS 10.14 & 10.15. The floor with Qt 6.5 is macOS 11.

@robertlipe
Copy link
Collaborator

robertlipe commented Jun 5, 2024 via email

@tsteven4 tsteven4 merged commit 44ceb47 into master Jun 5, 2024
33 checks passed
@tsteven4 tsteven4 deleted the macosci branch June 5, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants