Performance upgrade: %75 less parse time #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I parsed 10 tiff images at Chrome to measure the performance. I look the time spent in "parseTiff" function using chrome's profiler. results; original algorithm: 7685 ms new algorithm: 1819 ms Original algorithm was using CanvasRenderingContext2D.fillRect function to paint the canvas. New alorithm gets the pixel byte data using CanvasRenderingContext2D.getImageData function and put the rgba values directly into pixel array. Finally pixel array is put back to canvas using CanvasRenderingContext2D.putImageData function.
|
Sounds like a no-brainer merge to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I parsed 10 tiff images at Chrome to measure the performance. I look the
time spent in "parseTiff" function using chrome's profiler.
Results;
original algorithm: 7685 ms
new algorithm: 1819 ms
Differences in code;
Original algorithm was using CanvasRenderingContext2D.fillRect function
to paint the canvas. New alorithm gets the pixel byte data using
CanvasRenderingContext2D.getImageData function and put the rgba values
directly into pixel array. Finally pixel array is put back to canvas
using CanvasRenderingContext2D.putImageData function.