Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #53: Wysiwyg links #73

Closed
wants to merge 11 commits into from
Closed

Conversation

marcosgdf
Copy link
Collaborator

Improved dol_textishtml function.

Now it takes less memory and does a better HTML detection

Before:

Total Incl. Wall Time (microsec):   134 microsecs
Total Incl. CPU (microsecs):    0 microsecs
Total Incl. MemUse (bytes): 4,072 bytes
Total Incl. PeakMemUse (bytes): 0 bytes
Number of Function Calls:   17

After:

Total Incl. Wall Time (microsec):   42 microsecs
Total Incl. CPU (microsecs):    0 microsecs
Total Incl. MemUse (bytes): 3,992 bytes
Total Incl. PeakMemUse (bytes): 0 bytes
Number of Function Calls:   4

@marcosgdf
Copy link
Collaborator Author

Seems Scrutinizer errored. Not related with this PR though

@rdoursenaud
Copy link
Member

I don't think we need that on our repo. Upstream seems enough to me.

@marcosgdf
Copy link
Collaborator Author

Jean-Pierre once told me that contributions to Dolibarr must show that they were "sponsored/funded" by GPC, and so I make a PR to your fork and you do a PR to main dolibarr repo.

Should I push upstream then instead of here?

@rdoursenaud
Copy link
Member

Yes please. That was stupid of me to ask for more work ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants