Do not start nodes when deleting a project - #2833
Merged
grossmj merged 1 commit intoJul 26, 2026
Merged
Conversation
Project.delete() calls open() to rebuild the internal data structures needed for cleanup. open() schedules start_all() when the project has auto_start enabled, so deleting an auto-start project actually launched every node process, allocating ports and consuming resources, only for close() to kill them moments later. open() now takes an auto_start argument (default True, so normal opens are unchanged) and delete() passes auto_start=False. Fixes GNS3#2784
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2784
Project.delete()callsopen()to rebuild the data structures needed for cleanup, butopen()schedulesstart_all()whenauto_startis enabled — so deleting an auto-start project actually launches every node process, allocating ports and consuming resources, only for the followingclose()to kill them.open()now takes anauto_startargument (defaultTrue, so normal opens are unchanged) anddelete()passesauto_start=False. Addedtest_delete_does_not_start_nodes, which fails on master (start_allis called) and passes with the fix.