Skip to content

Add PR template. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
Related Issues: <!-- Add related issues here, e.g. #121 #341 -->
Requested Reviewers: @andrewtarzia <!-- Add other reviewers here -->
*Note for Reviewers: If you accept the review request add a :+1: to this post*

<!--
Talk about what a user would see (a big, a new feature) and what
user goals weren't being met. If the commit fixes a bug, describe how
the bug was discovered and steps to reproduce it, unless this is
already covered by the related issues. If this is a bug fix, what was
the mistake in the application logic? Be precise. Act like a detective
and report your findings.
-->

<!--
Why did you make the change this way? What other ways did you consider
but reject? Explain how amazing your work is.
-->

<!--
What risks are associated with making the changes in the commit? Will
anything else break? Are the changes backwards-compatible? Is there
any "tech debt"?
-->

<!--
Explain the source code changes. Changes that are fully explained in
code comments or the above paragraphs don't need to be repeated here.
Use bullet points, e.g.

* `src/dynsight/_internal/lens/lens.py:Lens.get_lens()`: The method
parameters were updated because <some reason>. The places where
the method was called were also updated.
-->

<!--
Give evidence that the commit works. Did you visually inspect any
changes to molecular structures yourself?
-->

<!--
The suggested PR outline is taken from
https://joshuatauberer.medium.com/write-joyous-git-commit-messages-2f98891114c4
-->
2 changes: 1 addition & 1 deletion .github/workflows/publish_release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ jobs:
twine upload
-u __token__
-p ${{ secrets.PYPI_API_TOKEN }}
dist/*
dist/*