-
-
Notifications
You must be signed in to change notification settings - Fork 6
Normalize Goats recipe activity levels #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: PR-9-Unleashthemods-update
Are you sure you want to change the base?
Normalize Goats recipe activity levels #214
Conversation
|
CodeAnt AI is reviewing your PR. |
| "survival", | ||
| 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The skills_required entry is currently a flat array and should be a list of skill/level pairs (nested array), e.g. wrap the pair in another array so it becomes [ [ "survival", 2 ] ]. [possible bug]
| "survival", | |
| 2 | |
| [ | |
| "survival", | |
| 2 | |
| ] |
Why Change? ⭐
The improved code converts the flat array of skill name and level into a nested array containing a single skill/level pair:
- The result is valid JSON and retains the trailing comma consistent with surrounding entries.
- This structure matches the common recipe schema where
skills_requiredis a list of [skill, level] pairs (i.e., an array of arrays), preventing misinterpretation by parsers that expect each skill to be its own pair. - The change is purely structural within the JSON and does not reference any external code or new identifiers, so it cannot introduce runtime errors by itself.
Assumptions: the recipe loader expects a list of skill/level pairs (nested arrays). Given that, this change is syntactically correct and aligns with expected schema.
| "throw", | ||
| 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Replace the malformed skills_required entry for atlatl (currently a flat array mixing a string and a number) with a nested pair array so it matches the other recipes' ["skill", level] structure. [possible bug]
| "throw", | |
| 2 | |
| [ | |
| "throw", | |
| 2 | |
| ] |
Why Change? ⭐
The improved code changes the flat array ["throw", 2] into a nested pair [["throw", 2]], matching the format used elsewhere in this file
(see other recipes where skills_required entries are arrays of [skill, level] pairs). This produces valid JSON and aligns with the
expected engine schema for skills_required (a list of skill/level tuples). The modification preserves types (string and integer),
includes proper punctuation and trailing comma as in the original context, and will not introduce syntax errors. Assumes the game/data
loader expects an array of skill pairs — which is supported by the surrounding recipe entries in this PR — therefore this fix is
executable and correct.
Changed the 'activity_level' field from 'LIGHT' to 'LIGHT_EXERCISE' in multiple recipe JSON files across several Goats mods. Also reformatted arrays for conciseness and consistency, improving readability and maintainability of recipe definitions.
User description
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68e59be9ec888333af02d44825ce628c
CodeAnt-AI Description
Normalize recipe activity levels to supported LIGHT/MODERATE categories
What Changed
Impact
✅ Accurate stamina drain when crafting teas, juices, and preserved foods✅ Fewer recipe compatibility/load errors due to unsupported activity labels✅ Consistent exertion labels for primitive crafting (canning, drying, container builds)💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.