Skip to content

Conversation

@TheGoatGod
Copy link
Member

@TheGoatGod TheGoatGod commented Oct 7, 2025

User description

Summary

  • update every Goats mod recipe to use the new LIGHT/MODERATE/BRISK activity levels, matching the most common level for each CDDA subcategory
  • default recipes without explicit subcategories to LIGHT so every recipe uses a supported activity level

Testing

  • not run (data-only change)

https://chatgpt.com/codex/tasks/task_e_68e59be9ec888333af02d44825ce628c


CodeAnt-AI Description

Normalize recipe activity levels to supported LIGHT/MODERATE categories

What Changed

  • Replaced deprecated or unsupported activity levels in many Goats-mod recipes so crafting now uses the new LIGHT or MODERATE activity categories.
  • User-visible crafting exertion updated for common items: teas and most drinks/juices, canned and pickled vegetables, dried mushrooms and many primitive survival recipes now show and apply LIGHT exertion; some primitive container builds (e.g., birch water jug/funnel) now show MODERATE exertion.
  • Recipes without an explicit compatible activity level now default to a supported LIGHT level so every recipe reports a valid exertion.
  • No changes to ingredients, results, or crafting times — only the exertion category (how much stamina/activity the player expends while crafting) and JSON formatting were adjusted.

Impact

✅ Accurate stamina drain when crafting teas, juices, and preserved foods
✅ Fewer recipe compatibility/load errors due to unsupported activity labels
✅ Consistent exertion labels for primitive crafting (canning, drying, container builds)

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@codeant-ai
Copy link

codeant-ai bot commented Oct 7, 2025

CodeAnt AI is reviewing your PR.

@codeant-ai codeant-ai bot added the size:XXL This PR changes 1000+ lines, ignoring generated files label Oct 7, 2025
Comment on lines 58 to 59
"survival",
2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: The skills_required entry is currently a flat array and should be a list of skill/level pairs (nested array), e.g. wrap the pair in another array so it becomes [ [ "survival", 2 ] ]. [possible bug]

Suggested change
"survival",
2
[
"survival",
2
]
Why Change? ⭐

The improved code converts the flat array of skill name and level into a nested array containing a single skill/level pair:

  • The result is valid JSON and retains the trailing comma consistent with surrounding entries.
  • This structure matches the common recipe schema where skills_required is a list of [skill, level] pairs (i.e., an array of arrays), preventing misinterpretation by parsers that expect each skill to be its own pair.
  • The change is purely structural within the JSON and does not reference any external code or new identifiers, so it cannot introduce runtime errors by itself.
    Assumptions: the recipe loader expects a list of skill/level pairs (nested arrays). Given that, this change is syntactically correct and aligns with expected schema.

Comment on lines 10 to 11
"throw",
2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Replace the malformed skills_required entry for atlatl (currently a flat array mixing a string and a number) with a nested pair array so it matches the other recipes' ["skill", level] structure. [possible bug]

Suggested change
"throw",
2
[
"throw",
2
]
Why Change? ⭐

The improved code changes the flat array ["throw", 2] into a nested pair [["throw", 2]], matching the format used elsewhere in this file
(see other recipes where skills_required entries are arrays of [skill, level] pairs). This produces valid JSON and aligns with the
expected engine schema for skills_required (a list of skill/level tuples). The modification preserves types (string and integer),
includes proper punctuation and trailing comma as in the original context, and will not introduce syntax errors. Assumes the game/data
loader expects an array of skill pairs — which is supported by the surrounding recipe entries in this PR — therefore this fix is
executable and correct.

Changed the 'activity_level' field from 'LIGHT' to 'LIGHT_EXERCISE' in multiple recipe JSON files across several Goats mods. Also reformatted arrays for conciseness and consistency, improving readability and maintainability of recipe definitions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex size:XXL This PR changes 1000+ lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants