Fixed dynamic loading of parallel quadratures#301
Merged
Conversation
…ature instead of pquadrature keyword.
Contributor
Author
|
Cannot dowload |
vladotomov
approved these changes
Jul 29, 2024
Member
vladotomov
left a comment
vladotomov
left a comment
There was a problem hiding this comment.
Now it works, thank you @najlkin.
Member
|
I restarted the CI and it all passes now 👍 |
tzanio
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes dynamic loading of parallel quadratures, which did not work with the "parallel ... quadrature" keywords after the first stream, but expected a special "pquadrature" keyword. Moreover, the loader of parallel grid functions was not checking the second keyword, so without any warning the parallel quadratures were treated as grid functions, leading to crashes 💣 . With this fix, "parallel ... quadrature" can be used consistently and the second keyword is checked properly.
Reported by: @vladotomov