Skip to content

Fixed mesh color with vector field options 4 and 5 in 3D#282

Merged
tzanio merged 1 commit intomasterfrom
najlkin/fix-mesh-color
May 30, 2024
Merged

Fixed mesh color with vector field options 4 and 5 in 3D#282
tzanio merged 1 commit intomasterfrom
najlkin/fix-mesh-color

Conversation

@najlkin
Copy link
Copy Markdown
Contributor

@najlkin najlkin commented May 29, 2024

This PR fixes the bug introduced in #237 , which causes that the mesh lines become gray after switching to the vector field visualization options 4 and 5, which use gray color for the arrows.

@najlkin
Copy link
Copy Markdown
Contributor Author

najlkin commented May 30, 2024

Perhaps, there could be a test with visualization of a vector field to prevent this in the future. Currently, I do not see any 🤔 .

Copy link
Copy Markdown
Member

@v-dobrev v-dobrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Jan!

@v-dobrev
Copy link
Copy Markdown
Member

Perhaps, there could be a test with visualization of a vector field to prevent this in the future. Currently, I do not see any 🤔 .

Not a high priority IMO. Up to you.

@tzanio tzanio merged commit 0a133c5 into master May 30, 2024
@tzanio tzanio deleted the najlkin/fix-mesh-color branch May 30, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants