Skip to content

Support for faces with holes in 3D#230

Merged
tzanio merged 4 commits intomasterfrom
cut-faces-dev
May 17, 2022
Merged

Support for faces with holes in 3D#230
tzanio merged 4 commits intomasterfrom
cut-faces-dev

Conversation

@tzanio
Copy link
Copy Markdown
Member

@tzanio tzanio commented May 14, 2022

Added the option to cut a portion of the interiors of 3D faces to expose more of the mesh. Useful as an alternative to transparency.

See keys Ctrl + F3 / F4.

Example:

Screen Shot 2022-05-13 at 5 46 51 PM

Inspired by:

@tzanio tzanio self-assigned this May 14, 2022
@tzanio tzanio added this to the glvis-4.2 milestone May 14, 2022
@tzanio
Copy link
Copy Markdown
Member Author

tzanio commented May 17, 2022

@mlstowell, @kanye-quest, @dylan-copeland, and @psocratis -- any chance I can get another approval on this PR?

@mlstowell
Copy link
Copy Markdown
Contributor

I like this feature but, unless I missed something, it looks like these cut triangles and quads are being displayed even if cut_lambda=0. Is that correct? If so, wouldn't it be more efficient to display a single triangle or quad?

@tzanio
Copy link
Copy Markdown
Member Author

tzanio commented May 17, 2022

I like this feature but, unless I missed something, it looks like these cut triangles and quads are being displayed even if cut_lambda=0. Is that correct? If so, wouldn't it be more efficient to display a single triangle or quad?

They shouldn't be, see e.g. this check: https://github.com/GLVis/glvis/pull/230/files#diff-8fd2270828db1d1202e66618a756d214a775cd82f71d29d9a92d475485a5b32dR747-R751

Am I missing something 🤔

Oh I see, you mean in PrepareFlat... I'll fix that

@tzanio
Copy link
Copy Markdown
Member Author

tzanio commented May 17, 2022

@mlstowell, see 9e3ceb8

@pazner pazner mentioned this pull request May 17, 2022
7 tasks
@tzanio tzanio merged commit 611746d into master May 17, 2022
@tzanio tzanio deleted the cut-faces-dev branch May 17, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants