Skip to content

Update numbering when a new mesh and solution is read#188

Merged
tzanio merged 2 commits intomasterfrom
numbering-fix-dev
Aug 20, 2021
Merged

Update numbering when a new mesh and solution is read#188
tzanio merged 2 commits intomasterfrom
numbering-fix-dev

Conversation

@rw-anderson
Copy link
Copy Markdown
Contributor

Fix to update numberings when a new mesh and solution is read in. This is important, for example, when the new mesh is adaptively refined.

@tzanio
Copy link
Copy Markdown
Member

tzanio commented Aug 14, 2021

Is this ready-for-review @rw-anderson ?

Copy link
Copy Markdown
Member

@tzanio tzanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bob!

@tzanio tzanio self-assigned this Aug 15, 2021
@tzanio tzanio added this to the glvis-4.1 milestone Aug 15, 2021
@tzanio tzanio changed the title update numbering when a new mesh and solution is read Update numbering when a new mesh and solution is read Aug 15, 2021
@rw-anderson
Copy link
Copy Markdown
Contributor Author

rw-anderson commented Aug 15, 2021

An unfortunate side effect of this change is that the warning about rendering for large meshes is spit out every time a new mesh and solution is read in.
I suppose with the work that's been done lately, I should test to make sure that's still a performance issue.
And secondly, if it still is, to only emit the warning when the numbering is requested with a keypress, not every time it goes through the pre-computation phase, so it doesn't pollute the output message space.

@publixsubfan
Copy link
Copy Markdown
Contributor

publixsubfan commented Aug 16, 2021

With the shader-based renderer (macOS, Linux, and WebGL clients), there shouldn't be a significant performance impact; we upload the text as a vertex buffer which is then transformed to the correct position inside the shader. There may be a performance impact with the legacy OpenGL renderer (remote X11 or with -oldgl switch), since we have to issue draw calls for each triangle in the text.

That being said, drawing triangles should be much faster than drawing bitmaps, which was the main performance issue with the old numbering stuff.

@tzanio
Copy link
Copy Markdown
Member

tzanio commented Aug 16, 2021

@rw-anderson can you test and let us know how best to resolve #188 (comment)?

I'll hold on merging this until then.

@tzanio tzanio mentioned this pull request Aug 16, 2021
15 tasks
@tzanio
Copy link
Copy Markdown
Member

tzanio commented Aug 19, 2021

@rw-anderson any progress?

(We want to have most of the glvis-4.1 PRs merged by the end of this week)

@rw-anderson
Copy link
Copy Markdown
Contributor Author

Sorry I haven't looked at this again yet. I should be able to take a look on Friday.

@tzanio
Copy link
Copy Markdown
Member

tzanio commented Aug 20, 2021

Friday is OK, thanks!

@rw-anderson
Copy link
Copy Markdown
Contributor Author

I tested it and performance seems fine with the latest code, so I'm just removing the mesh size limitation.

@tzanio tzanio merged commit fdb0612 into master Aug 20, 2021
@tzanio tzanio deleted the numbering-fix-dev branch August 20, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants