[DO NOT MERGE] Regression testing + screenshot fix#176
Closed
publixsubfan wants to merge 78 commits intomasterfrom
Closed
[DO NOT MERGE] Regression testing + screenshot fix#176publixsubfan wants to merge 78 commits intomasterfrom
publixsubfan wants to merge 78 commits intomasterfrom
Conversation
…ter event loop starts
publixsubfan
force-pushed
the
regression-testing-dev
branch
from
94ff671 to
e60b9ba
Compare
publixsubfan
changed the title
publixsubfan
changed the title
Co-authored-by: Adrien Bernede <51493078+adrienbernede@users.noreply.github.com>
Co-authored-by: Adrien Bernede <51493078+adrienbernede@users.noreply.github.com>
Member
|
Can you please resolve the conflicts? |
Merged
Contributor
Author
|
Closing in favor of #189 |
Member
|
Remember to delete this branch once #189 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds initial regression testing based on stream-based screenshot generation.
Also, in the process of getting this working, I discovered that some OpenGL implementations (namely, Mesa's llvmpipe software renderer) don't support reading from the front buffer. To fix this, an expose event/call is issued before taking the screenshot, so that the
Screenshot()call grabs the back buffer data instead.Resolves #124