Merged
Conversation
tzanio
approved these changes
Sep 2, 2022
Member
tzanio
left a comment
tzanio
left a comment
There was a problem hiding this comment.
I've seen cases where this is a bit fragile, but it is a huge improvement already so lets merge it!
Member
|
@kanye-quest and @jandrej -- are you interested in reviewing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for parallel streams.
glvis-browser-serverwill now handle messages with theparallel <nproc> <rank>header; when it sees one it will wait for/build a list with 1 message from each rank then jsonify and write the message. The behavior for serial messages remains unchanged.The
livepage with look for json array messages (those that start with[) and decode them.The stream-list messages are repacked into an Emscripten
std::vector<std::string>wrapper (StringArray) then passed to the newdisplayParallelStreams/updateParallelStreamsmethods. This approach seems non-optimal but it works for now.The
data_typeprocessing has been removed from the web side and now lives in the compiled code.Depends on GLVis/glvis#235