Skip to content

Conversation

@kentbull
Copy link
Collaborator

@kentbull kentbull commented Feb 7, 2025

This PR does the following:

  • Adds the proper "sally" block to the Habery bootstrap config file so that the proper controller /loc/scheme reply message is added to the OOBI resolve output.
  • Adds a --salt arg to sally server start and passes it through to the Habery creation so that separate initialization and inception are no longer required.
  • Adds a --loglevel command to sally server start so that the log level can be configured by command line argument.
  • Adds a healthcheck endpoint at /health that shows a health message, the version of Sally, and some basic metrics.

A sample healthcheck response looks like this:

{
  "message": "Health is okay. Time is 2025-02-06T23:49:47.673704+00:00", 
  "version": "0.9.4", 
  "counts": {
    "senders": 0, 
    "iss": 0, 
    "rev": 0, 
    "recv": 0, 
    "revk": 0, 
    "ack": 0
  }
}

@kentbull kentbull requested a review from m00sey February 7, 2025 00:34
@kentbull kentbull force-pushed the salt-health-metrics-curls-config branch 2 times, most recently from a0897e6 to 6650300 Compare February 7, 2025 22:09
@kentbull kentbull changed the title feat: add salt and logging args, health endpoint, and curls config feat: controller mode with SallyAgent, add salt and logging args, health endpoint, curls config, better logging Feb 8, 2025
@kentbull kentbull force-pushed the salt-health-metrics-curls-config branch 3 times, most recently from 3336cf3 to b192dc7 Compare February 10, 2025 02:30
@kentbull kentbull marked this pull request as draft March 21, 2025 23:37
@kentbull kentbull force-pushed the salt-health-metrics-curls-config branch from b192dc7 to a1fd19c Compare March 25, 2025 23:11
@kentbull kentbull force-pushed the salt-health-metrics-curls-config branch from a1fd19c to 33b44da Compare March 25, 2025 23:12
@kentbull
Copy link
Collaborator Author

I force-pushed this today after updating it to the latest code since merging 0.10.0 to main. This will be v1.0.0.

Once I test it again and verify both indirect and direct mode continue to produce the same results then I will take this from draft to ready to review.

@kentbull
Copy link
Collaborator Author

closing in favor of the new direct-mode branch PR.

@kentbull kentbull closed this Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant