CI CD workflows #4
Conversation
laruh
commented
Oct 6, 2024
- provides lint, fmt checks and unit tests in workflows
- fixes fmt and clippy
55cc2ac to
0f0ccf8
Compare
…e_candidate_1-ci-cd # Conflicts: # src/types/atomic_swap.rs
…e_candidate_1-ci-cd # Conflicts: # src/tests/spend_policy.rs
|
@Alrighttt Hi, one of the tests is failing. Pinging you in case you didn’t see it |
|
This is utilizing an unmaintained project, actions-rs. Could you please research an alternative? The github runner should have rustup by default. It doesn't seem necessary to use an action. I believe it could be as simple as this. |
…e_candidate_1-ci-cd # Conflicts: # src/transport/client/helpers.rs # src/types/atomic_swap.rs
What you've provided is a manual toolchain installation, it has the same result as steps made in actions. Did you re check error message, it has nothing to do with actions-rs/toolchain@v1 (it is for more convenient toolchain installation setup in yml file and nothing more) |
actions-rs/cargo#59 (comment) The error can be tagged with |
|
@Alrighttt sorry I misread your first message, I thought it was the answer to my note about failing test as for test: delete it or ignore, its up to you in release candidate branch |
ac95bcb to
fbfe97a
Compare
Alrighttt
left a comment
There was a problem hiding this comment.
Dummy review to remove this from my https://github.com/pulls/review-requested

