Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move oshdb-api's backend implementation into separate submodule(s) #387

Merged
merged 12 commits into from
Jun 22, 2021

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Jun 17, 2021

Description

This creates a new submodules oshdb-api-ignite which contains the backend implementation code for running OSHDB queries on ignite.

I kept the JDBC/H2 backend implementation in the oshdb-api module for now, since it is a relatively lightweight (from a code and probably also from a dependencies point of view), and pulling it out would come with some annoyances: mainly that most tests (even the ones in ignite) use the H2 backend implementation as a "default" backend to run queries and/or to access keytables.

Some of the above points could be solved in the future (e.g. grid-included keytables, implementing a special in-memory "dummy" backend for tests, etc.). So, perhaps it's better to have a separate oshdb-api-jdbc (oshdb-api-h2) module already now? //edit: it would likely look more or less like this in at the moment: #388

PS: This also upgrades ignite to the newest version (2.10.0).

Corresponding issue

Closes #16 (?)
Closes #386

New or changed dependencies

  • introduced new submodule oshdb-api-ignite
  • moved ignite dependencies from oshdb-api to the new module

Checklist

@tyrasd tyrasd added enhancement New feature or request dependencies referes to one of our dependencies comments welcome Indicates that the creator of this issue/PR is open for early review comments labels Jun 17, 2021
@tyrasd tyrasd added this to the release 0.7.0 milestone Jun 17, 2021
Copy link
Member

@joker234 joker234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question: do we plan to add more backends? If yes, we could use a sub-groupId like this:

<groupId>org.heigit.ohsome.oshdb-backend</groupId>
<artifactId>ignite-backend</artifactId>

@tyrasd tyrasd force-pushed the backend-modularity branch 3 times, most recently from 54edd75 to 78ffcdc Compare June 18, 2021 11:29
@tyrasd
Copy link
Member Author

tyrasd commented Jun 18, 2021

General question: do we plan to add more backends? If yes, we could use a sub-groupId like this:

<groupId>org.heigit.ohsome.oshdb-backend</groupId>
<artifactId>ignite-backend</artifactId>

IMHO a realistic number would be that we eventually have maybe 3 or 4 actively maintained backend implementations. I think it's fine to keep the flat structure for now.

@tyrasd tyrasd added the breaking This will introduce an incombability to previous versions. Documentation update compulsory label Jun 18, 2021
@tyrasd tyrasd changed the title 🚧 Move oshdb-api's backend implementation into separate submodule(s) Move oshdb-api's backend implementation into separate submodule(s) Jun 22, 2021
@tyrasd tyrasd force-pushed the backend-modularity branch from d24ed35 to 42fbe79 Compare June 22, 2021 10:25
@tyrasd tyrasd added waiting for review This pull request needs a code review and removed comments welcome Indicates that the creator of this issue/PR is open for early review comments labels Jun 22, 2021
joker234
joker234 previously approved these changes Jun 22, 2021
Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
@tyrasd tyrasd merged commit 1a0f2f8 into master Jun 22, 2021
@tyrasd tyrasd deleted the backend-modularity branch June 22, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This will introduce an incombability to previous versions. Documentation update compulsory dependencies referes to one of our dependencies enhancement New feature or request waiting for review This pull request needs a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Apache Ignite to the newest version Moving dependent code of Ignite/JDBC/H2 to own sub modules
2 participants