-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move oshdb-api's backend implementation into separate submodule(s) #387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General question: do we plan to add more backends? If yes, we could use a sub-groupId like this:
<groupId>org.heigit.ohsome.oshdb-backend</groupId>
<artifactId>ignite-backend</artifactId>
54edd75
to
78ffcdc
Compare
IMHO a realistic number would be that we eventually have maybe 3 or 4 actively maintained backend implementations. I think it's fine to keep the flat structure for now. |
also drop unnecessary <relativePath> for parents – which was just replicating the default value anyway, and should have actually pointed to the parent's "pom.xml" see http://maven.apache.org/ref/3.0/maven-model/maven.html#parent
d24ed35
to
42fbe79
Compare
oshdb-api/src/test/java/org/heigit/ohsome/oshdb/api/tests/TestMapReduce.java
Show resolved
Hide resolved
Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
Description
This creates a new submodules
oshdb-api-ignite
which contains the backend implementation code for running OSHDB queries on ignite.I kept the JDBC/H2 backend implementation in the
oshdb-api
module for now, since it is a relatively lightweight (from a code and probably also from a dependencies point of view), and pulling it out would come with some annoyances: mainly that most tests (even the ones in ignite) use the H2 backend implementation as a "default" backend to run queries and/or to access keytables.Some of the above points could be solved in the future (e.g. grid-included keytables, implementing a special in-memory "dummy" backend for tests, etc.). So, perhaps it's better to have a separate
oshdb-api-jdbc
(oshdb-api-h2
) module already now? //edit: it would likely look more or less like this in at the moment: #388PS: This also upgrades ignite to the newest version (
2.10.0
).Corresponding issue
Closes #16 (?)
Closes #386
New or changed dependencies
oshdb-api-ignite
oshdb-api
to the new moduleChecklist
I have made corresponding changes to the documentationI have adjusted the examples or created an issue in the corresponding repositoryI have adjusted the benchmark or created an issue in the corresponding repository-> https://gitlab.gistools.geog.uni-heidelberg.de/giscience/big-data/ohsome/oshdb-benchmarks/-/blob/master/pom.xml