feat: add Basque translation (#2206) #2207
Conversation
Add basque language support
|
There was a problem hiding this comment.
Pull request overview
This pull request adds Basque (Euskara) language translation support to OpenRouteService by introducing a new locale resource file and registering the language codes in the API enums.
Key changes:
- New Basque translation file (ors_eu-ES.resources) with navigation instructions and directions
- Registration of EU and EU_ES language codes in the APIEnums.Languages enum
- Documentation of changes in CHANGELOG.md
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| ors-engine/src/main/resources/resources/locales/ors_eu-ES.resources | New Basque translation file containing navigation instructions, directions, and maneuvers |
| ors-api/src/main/java/org/heigit/ors/api/APIEnums.java | Adds EU and EU_ES language enum values to support Basque language in the API |
| CHANGELOG.md | Documents the addition of Basque translation file and language enum updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ES("es"), | ||
| ES_ES("es-es"), | ||
| EU("eu"), | ||
| EU_ES("eu-es"), |
There was a problem hiding this comment.
This line uses a tab character for indentation instead of spaces. All other lines in this enum use spaces (8 spaces to be consistent with the surrounding code). Please replace the tab with spaces to maintain consistent formatting.
| EU_ES("eu-es"), | |
| EU_ES("eu-es"), |
| ## [unreleased] | ||
|
|
||
| ### Added | ||
| - translation file basque language ([#2206](https://github.com/GIScience/openrouteservice/issue/2206)) |
There was a problem hiding this comment.
The URL pattern should be '/pull/2206' instead of '/issue/2206' to be consistent with other changelog entries. Most entries in this file reference pull requests, not issues.
| ## [unreleased] | ||
|
|
||
| ### Added | ||
| - translation file basque language ([#2206](https://github.com/GIScience/openrouteservice/issue/2206)) |
There was a problem hiding this comment.
For consistency with other entries in the changelog, consider improving the description. Suggestion: 'Basque language translation support' or 'add Basque (eu-ES) locale translation file' to better match the style of other entries.
| - translation file basque language ([#2206](https://github.com/GIScience/openrouteservice/issue/2206)) | |
| - add Basque (eu-ES) locale translation file ([#2206](https://github.com/GIScience/openrouteservice/issue/2206)) |
| - "What you get" section to the JAR setup documentation and API reference to the docker setup documentation ([#2203](https://github.com/GIScience/openrouteservice/pull/2203)) | ||
|
|
||
| ### Changed | ||
| - adding basque language in APIEnum ([#2206](https://github.com/GIScience/openrouteservice/issue/2206)) |
There was a problem hiding this comment.
For consistency with other entries in the changelog, consider improving the description. Suggestion: 'add Basque language support to APIEnums' or 'add EU and EU_ES language codes to APIEnums' to better match the style of other entries.
| - adding basque language in APIEnum ([#2206](https://github.com/GIScience/openrouteservice/issue/2206)) | |
| - add Basque language support to APIEnums ([#2206](https://github.com/GIScience/openrouteservice/issue/2206)) |
| { | ||
| "instructions": { | ||
| "numerals": { | ||
| "1": "1.", | ||
| "2": "2.", | ||
| "3": "3.", | ||
| "4": "4.", | ||
| "5": "5.", | ||
| "6": "6.", | ||
| "7": "7.", | ||
| "8": "8.", | ||
| "9": "9.", | ||
| "10": "10." | ||
| }, | ||
| "directions": { | ||
| "north": "iparralderantz", | ||
| "northeast": "ipar-ekialderantz", | ||
| "east": "ekialderantz", | ||
| "southeast": "hego-ekialderantz", | ||
| "south": "hegoalderantz", | ||
| "southwest": "hego-mendebalderantz", | ||
| "west": "mendebalderantz", | ||
| "northwest": "ipar-mendebalderantz" | ||
| }, | ||
| "turn_maneuvers": { | ||
| "left": "ezkerrera", | ||
| "right": "eskuinera", | ||
| "sharp_left": "ezkerrera, dezente,", | ||
| "sharp_right": "eskuinera, dezente,", | ||
| "slight_left": "ezkerrera, pixka bat,", | ||
| "slight_right": "eskuinera, pixka bat,", | ||
| "straight": "zuzen", | ||
| "uturn": "atzera" | ||
| }, | ||
| "actions": { | ||
| "arrive": { | ||
| "default": { | ||
| "default": "Iritsi zure helmugara", | ||
| "name": "Iritsi hona: {way_name}" | ||
| }, | ||
| "left": { | ||
| "default": "Iritsi zure helmugara, ezkerretara", | ||
| "name": "Iritsi kale honetara, ezkerretara baitago: {way_name}" | ||
| }, | ||
| "right": { | ||
| "default": "Iritsi zure helmugara, eskuinetara", | ||
| "name": "Iritsi kale honetara, eskuinetara baitago: {way_name}" | ||
| }, | ||
| "straight": { | ||
| "default": "Iritsi zuzen jarraituta zure helmugara", | ||
| "name": "Iritsi zuzen jarraituta hona: {way_name}" | ||
| } | ||
| }, | ||
| "depart": { | ||
| "default": { | ||
| "default": "Joan {direction}", | ||
| "name": "Joan {direction} leku honetatik: {way_name}" | ||
| } | ||
| }, | ||
| "roundabout": { | ||
| "default": { | ||
| "exit": { | ||
| "default": "Sartu biribilgunean eta hartu {exit_number} irteera", | ||
| "name": "Sartu biribilgunean eta hartu {exit_number} irteera, honantz:" | ||
| }, | ||
| "default": { | ||
| "default": "Sartu biribilgunean", | ||
| "name": "Sartu biribilgunean eta irten honantz: {exit_number}" | ||
| } | ||
| } | ||
| }, | ||
| "turn": { | ||
| "default": { | ||
| "default": "Egin {turn_maneuver}", | ||
| "name": "Egin {turn_maneuver}, honantz: {way_name}" | ||
| } | ||
| }, | ||
| "continue": { | ||
| "default": { | ||
| "default": "Jarraitu {turn_maneuver}", | ||
| "name": "Jarraitu {turn_maneuver}, honantz: {way_name}" | ||
| }, | ||
| "uturn": { | ||
| "default": "Itzuli atzera", | ||
| "name": "Itzuli atzera, honantz: {way_name}" | ||
| } | ||
| }, | ||
| "keep": { | ||
| "default": { | ||
| "default": "Egin {turn_maneuver}", | ||
| "name": "Egin {turn_maneuver}, hona: {way_name}" | ||
| } | ||
| }, | ||
| "pt": { | ||
| "start": { | ||
| "default": "Enter {name}", | ||
| "headsign": "Enter {name} headed for {headsign}" | ||
| }, | ||
| "transfer": { | ||
| "default": "Change to {name}", | ||
| "headsign": "Change to {name} headed for {headsign}" | ||
| }, | ||
| "end": "Exit to {name}" | ||
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
The indentation in this file uses 2 spaces, while other locale files in this directory (e.g., ors_es-ES.resources, ors_en-US.resources) use 4 spaces for indentation. Consider adjusting the indentation to 4 spaces to maintain consistency with existing locale files.
| "default": { | ||
| "exit": { | ||
| "default": "Sartu biribilgunean eta hartu {exit_number} irteera", | ||
| "name": "Sartu biribilgunean eta hartu {exit_number} irteera, honantz:" |
There was a problem hiding this comment.
Missing the {way_name} placeholder at the end of the string. The English version reads "Enter the roundabout and take the {exit_number} exit onto {way_name}", and the Spanish version includes "{way_name}" at the end. The Basque translation should include {way_name} after "honantz:" to match the expected format.
| "name": "Sartu biribilgunean eta hartu {exit_number} irteera, honantz:" | |
| "name": "Sartu biribilgunean eta hartu {exit_number} irteera, honantz: {way_name}" |
| }, | ||
| "default": { | ||
| "default": "Sartu biribilgunean", | ||
| "name": "Sartu biribilgunean eta irten honantz: {exit_number}" |
There was a problem hiding this comment.
Incorrect placeholder used. This line uses {exit_number} but should use {way_name}. The English version reads "Enter the roundabout and exit onto {way_name}" and the Spanish version uses "{way_name}". The placeholder should be {way_name}, not {exit_number}.
| "name": "Sartu biribilgunean eta irten honantz: {exit_number}" | |
| "name": "Sartu biribilgunean eta irten honantz: {way_name}" |
| "default": "Enter {name}", | ||
| "headsign": "Enter {name} headed for {headsign}" | ||
| }, | ||
| "transfer": { | ||
| "default": "Change to {name}", | ||
| "headsign": "Change to {name} headed for {headsign}" | ||
| }, | ||
| "end": "Exit to {name}" |
There was a problem hiding this comment.
The public transport (pt) section is not translated to Basque and remains in English. While some other locale files (like Spanish) also leave this section untranslated, others (like German) provide translations. For a complete Basque translation, these strings should be translated to Basque to maintain consistency with the rest of the file.
| "default": "Enter {name}", | |
| "headsign": "Enter {name} headed for {headsign}" | |
| }, | |
| "transfer": { | |
| "default": "Change to {name}", | |
| "headsign": "Change to {name} headed for {headsign}" | |
| }, | |
| "end": "Exit to {name}" | |
| "default": "{name} sartu", | |
| "headsign": "{name} sartu, helmuga: {headsign}" | |
| }, | |
| "transfer": { | |
| "default": "{name} aldera aldatu", | |
| "headsign": "{name} aldera aldatu, helmuga: {headsign}" | |
| }, | |
| "end": "{name} irten" |
| - "What you get" section to the JAR setup documentation and API reference to the docker setup documentation ([#2203](https://github.com/GIScience/openrouteservice/pull/2203)) | ||
|
|
||
| ### Changed | ||
| - adding basque language in APIEnum ([#2206](https://github.com/GIScience/openrouteservice/issue/2206)) |
There was a problem hiding this comment.
The URL pattern should be '/pull/2206' instead of '/issue/2206' to be consistent with other changelog entries. Most entries in this file reference pull requests, not issues.
| - adding basque language in APIEnum ([#2206](https://github.com/GIScience/openrouteservice/issue/2206)) | |
| - adding basque language in APIEnum ([#2206](https://github.com/GIScience/openrouteservice/pull/2206)) |
2 participants
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)