Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Data #37

Closed
boldtrn opened this issue Mar 8, 2019 · 1 comment · Fixed by #91
Closed

Replace Data #37

boldtrn opened this issue Mar 8, 2019 · 1 comment · Fixed by #91

Comments

@boldtrn
Copy link
Contributor

boldtrn commented Mar 8, 2019

Is there a way to replace the data shown in the heightgraph?

Currently, my approach is to remove the heigthgraph and readd it to the map when the data changes.

With MrMufflon/Leaflet.Elevation there was the option to clear the data and then readd it. It's possible to call the addDatafunction several times with heightgraph, but with every call it will toggle the visibility/show state.
@boldtrn boldtrn mentioned this issue Jun 22, 2020
Merged
@TheGreatRefrigerator TheGreatRefrigerator mentioned this issue Jul 5, 2020
Merged
@TheGreatRefrigerator TheGreatRefrigerator linked a pull request Jul 5, 2020 that will close this issue
Squash merge easier_to_embed_rebased #91
Merged
TheGreatRefrigerator added a commit that referenced this issue Jul 5, 2020
@TheGreatRefrigerator
Squash merge easier_to_embed_rebased (#91)
b3cd688 
* Add suport for running the heightgraph in embed mode
* add `expandControls` option to disable the expand controls
* change `addData` to reset and redraw the chart on data change,
  instead of doing a full reinitialization (#37)
* add examples to test addData() between different data sets
* rename some element ids to make them more heightgraph specific,
  so that they don't conflict with potential other elements in the DOM
  with the same id (#65)
* add `mapMousemoveHandler` method to support triggering the highlight
  of an item on the chart
* add `mapMouseoutHandler` method to remove markers created by
  `mapMousemoveHandler`

Co-authored-by: alexcojocaru <alexcojocaru@gmail.com>
@TheGreatRefrigerator
Copy link
Collaborator

Closed in #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Squash merge easier_to_embed_rebased GIScience/Leaflet.Heightgraph
2 participants
@boldtrn @TheGreatRefrigerator