Skip to content

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Apr 16, 2025

Closes #355

This PR allow for fixtures to not have a develop: key in components.yaml.

I'm keeping draft as for some reason rye test isn't working for me locally, so I want @pchakraborty to double check.

Also, maybe a test should be added to test this situation? Dunno if it's worth that...

@mathomp4 mathomp4 added the bugfix This fixes a bug label Apr 16, 2025
@mathomp4 mathomp4 self-assigned this Apr 16, 2025
@mathomp4 mathomp4 marked this pull request as ready for review April 16, 2025 14:21
@mathomp4 mathomp4 requested a review from a team as a code owner April 16, 2025 14:21
Copy link
Collaborator

@pchakraborty pchakraborty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pchakraborty pchakraborty merged commit b5be152 into main Apr 16, 2025
16 checks passed
mathomp4 added a commit that referenced this pull request Apr 24, 2025
Co-authored-by: Purnendu Chakraborty <purnendu.chakraborty@nasa.gov>
Fixes #355. Allow for fixture without develop key (#356)
Fixes #355. Allow for fixture without develop key
Fix issue with checkout and submodules (#359)
@pchakraborty pchakraborty deleted the hotfix/#355-fix-fixture-develop branch April 28, 2025 18:26
pchakraborty added a commit that referenced this pull request Apr 30, 2025
* Fixes #355. Allow for fixture without develop key (#356)

* Fixes #355. Allow for fixture without develop key

* Fix per black

* A small change to make it just a little easier to add required and optional keys for fixtures

---------

Co-authored-by: Purnendu Chakraborty <purnendu.chakraborty@nasa.gov>

* Fix issue with checkout and submodules (#359)

* Fix issue with checkout and submodules

* Black formatter

* First try at migrating from rye to uv

* Updated CHANGELOG.md

---------

Co-authored-by: Matt Thompson <matthew.thompson@nasa.gov>
pchakraborty added a commit that referenced this pull request Apr 30, 2025
* Fixes #355. Allow for fixture without develop key (#356)

* Fixes #355. Allow for fixture without develop key

* Fix per black

* A small change to make it just a little easier to add required and optional keys for fixtures

---------

Co-authored-by: Purnendu Chakraborty <purnendu.chakraborty@nasa.gov>

* Fix issue with checkout and submodules (#359)

* Fix issue with checkout and submodules

* Black formatter

* Streamlined code for processing output of git status

* Moved coloring of On branch feature/pchakrab/#353-status-ahead-behind
Your branch is up to date with 'origin/feature/pchakrab/#353-status-ahead-behind'.

Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	�[32mmodified:   command/status.py�[m
	�[32mmodified:   git.py�[m to command/status.py. Also added ahead/behind/stash info

* Minor formatting

* Updated CHANGELOG.md

* Removed mepo.spec which is not being used

---------

Co-authored-by: Matt Thompson <matthew.thompson@nasa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mepo requires develop key for fixtures
2 participants