Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for timestep propagation in hierarchy. #3423

Open
wants to merge 2 commits into
base: release/MAPL-v3
Choose a base branch
from
Open

Added tests for timestep propagation in hierarchy. #3423

wants to merge 2 commits into from
+285 −23

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Feb 12, 2025

  • Exposed at least one bug in MAPL3 logic (fixed)
  • Exposed bug or weakness in documentation in ESMF alarms . ringtime must be start time or future time even for recurring alarm.

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Added unit tests and fixed bugs that were exposed.

Related Issue

@tclune
Added tests for timestep propagation in hierarchy.
a0969e2 
- Exposed at least one bug in MAPL3 logic (fixed)
- Exposed bug or weakness in documentation in ESMF alarms . ringtime
  must be start time or future time even for recurring alarm.
@tclune tclune added 🪲 Bugfix This fixes a bug! 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Feb 12, 2025
@tclune tclune requested a review from a team as a code owner February 12, 2025 22:05
@tclune tclune requested a review from atrayano February 12, 2025 22:07
@tclune tclune added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrayano atrayano Awaiting requested review from atrayano

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug! Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tclune