Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo ACG typo: 'num_subtitles' => 'num_subtiles' - Mais non! #3396

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

darianboggs
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

The argument num_subtiles from the MAPL_Add___Spec subroutine was spelled num_subtitles in the automatic code generator. Since MAPL does not use subtitles (or dubbing), this was obviously a mistake of the gravest nature. We apologise for the fault in the subtitles. Those responsible have been sacked..

@darianboggs darianboggs added the 🪲 Bugfix This fixes a bug! label Feb 7, 2025
@darianboggs darianboggs self-assigned this Feb 7, 2025
@darianboggs darianboggs requested a review from a team as a code owner February 7, 2025 17:50
Copy link

github-actions bot commented Feb 7, 2025

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, 😲 Non 0 Diff, 🔧 Github Actions. Please add one so that the PR can be merged.

@mathomp4 mathomp4 merged commit c9d17a6 into develop Feb 7, 2025
8 of 27 checks passed
@mathomp4 mathomp4 deleted the bugfix/wdboggs/rm_subtiles_typo_acg branch February 7, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 Bugfix This fixes a bug!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants