Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad esmf target in MAPL3:hconfig_utils #3296

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jan 9, 2025

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

In testing Spack and MAPL3, I found one of our CMake targets for ESMF was not ESMF::ESMF. This fixes that.

Related Issue

@mathomp4 mathomp4 added 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Jan 9, 2025
@mathomp4 mathomp4 self-assigned this Jan 9, 2025
@mathomp4 mathomp4 requested a review from a team as a code owner January 9, 2025 16:58
Copy link

github-actions bot commented Jan 9, 2025

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, 😲 Non 0 Diff, 🔧 Github Actions. Please add one so that the PR can be merged.

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Jan 9, 2025
@mathomp4 mathomp4 merged commit 80afc89 into release/MAPL-v3 Jan 9, 2025
48 of 51 checks passed
@mathomp4 mathomp4 deleted the bugfix/mathomp4/spack-mapl3 branch January 9, 2025 20:04
@mathomp4 mathomp4 mentioned this pull request Jan 9, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants