Skip to content

feat: Create Soreide-Whitson fluid model #3606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

dkachuma
Copy link
Contributor

@dkachuma dkachuma commented Mar 20, 2025

Adds the Soreide-Whitson fluid model

  • Creates a FlashData object to hold parameters required for the flash. The point of this is that as we have different EoS and different flashes, they may need different parameters (e.g. salinity) and this object encapsulates all the parameters.
  • Adds the Soreide-Whitson equation of state to the enumeration. Adds it to FugacityCalculator and CompositionalDensityUpdate.
  • Fixes a typo in the CO2-H2O SW binary interaction coefficient.
  • Creates a two phase fluid model (CompositionalTwoPhasePhillipsBrine) with a Phillips brine as a liquid phase and a compositional fluid as a gas phase.

@dkachuma dkachuma self-assigned this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant