refactor: Reorganise constitutive tests #3581
Conversation
dkachuma
changed the title
dkachuma
added
the
ci: run integrated tests
dkachuma
requested review from
rrsettgast,
CusiniM,
corbett5,
wrtobin and
jhuang2601
as code owners
dkachuma
changed the title
|
I think it would be better to make the drivers standalone executables and transform these tests into integratedTests. |
These tests are complete geos input files that can be run directly with the |
…ps://github.com/GEOS-DEV/GEOS into refactor/dkachuma/reorganise-constitutive-tests
| Returns: | ||
| geos.hdf5_wrapper: The hdf5 wrapper for the data | ||
| """ | ||
|
|
There was a problem hiding this comment.
are you doing this so that you can then use a curve_check ? This is good for now. In the future we may want to simply output an hdf5 directly from the constitutiveDriver.
| @@ -53,24 +53,4 @@ | |||
| </Events> | |||
|
|
|||
| <!-- SPHINX_PVTDRIVER_EVENTS_END --> | |||
| <!-- Mesh is not used, but GEOSX throws an error without one. Will resolve soon--> | |||
| <Mesh> | |||
There was a problem hiding this comment.
were you able to resolver the need for the mesh? I don't see it in this PR but if that's the case, it's great!
The directory
src/coreComponents/unitTests/constitutiveTestsis getting clattered with constitutive driver based tests. This PR moves all the driver based test xmls into a sub-directorydriverTestsand all their baselines tobaselines. The idea is to keepsrc/coreComponents/unitTests/constitutiveTestsfor the actual c++ tests.