-
Notifications
You must be signed in to change notification settings - Fork 39
feat(radio): Radio element and radiogroup init #2406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: minor
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The radiogroup
should be almost identical to the text
dropdown entry method but only allowing a single selection.
It should support getting the values from a query - it should support everything a text
entry, does with the caveat you can only select one value :)
Radiobutton is a boolean at its root. It only knows if it's on or off. Value updates and callbacks should be handled with onchange radiogroup event and will be added later outside this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't match the specification of the ticket. I'd like to see the radio element first as a susbtitute for a single select dropdown element before creating a complex multiple related boolean fields use case and then finding a problem for this solution.
Creates:
Possible configuration requires at least 2 boolean fields meant to be mutually exclusive.
Checking one unchecks all others.
Use case: select model type and use only relevant input - conditionals within on change callbacks at a further stage.