Skip to content

Conversation

dbauszus-glx
Copy link
Member

@dbauszus-glx dbauszus-glx commented Sep 2, 2025

The aim of this PR is to introduce login and registration forms which make use of the dictionary. There should not be duplicate views for different languages.

It must be possible to load the mapp library without the mapp css or the ol library loaded. This previously crashed out and has been addressed in the mapp.mjs module.

It should be possible to load the ui library before or without the mapp library without the the ui.mjs crashing.

tbd
The styling for the loginForm element shoulld be defined in the ui.css
The loginForm element should work without the need for element id

@dbauszus-glx dbauszus-glx self-assigned this Sep 2, 2025
@dbauszus-glx dbauszus-glx linked an issue Sep 2, 2025 that may be closed by this pull request
@dbauszus-glx dbauszus-glx added Bug A genuine bug. There must be some form of error exception to work with. Feature New feature requests or changes to the behaviour or look of existing application features. Code Issues related to the code structure and performance. CSS Changes in stylesheets labels Sep 3, 2025
@cityremade
Copy link
Member

cityremade commented Sep 22, 2025

Restored password input pattern attribute.
Added general validation error message.
Minor tweaks like asterisks for required fields.
One more entry needed for dictionaries then, register_error.

Copy link
Contributor

@AlexanderGeere AlexanderGeere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected!

@dbauszus-glx
Copy link
Member Author

I added some missing dictionary entries for Spanish registration.

image

@RobAndrewHurst RobAndrewHurst changed the title Login and Register language templates and forms fix(login/register): language templates and forms Sep 25, 2025
Copy link

@RobAndrewHurst RobAndrewHurst dismissed simon-leech’s stale review September 25, 2025 15:17

This has been resolved

@RobAndrewHurst RobAndrewHurst merged commit 15f6c91 into GEOLYTIX:minor Sep 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with. Code Issues related to the code structure and performance. CSS Changes in stylesheets Feature New feature requests or changes to the behaviour or look of existing application features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language login and registration templates
6 participants