Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit pipeline io #82

Merged
merged 7 commits into from
Sep 19, 2023
Merged

Edit pipeline io #82

merged 7 commits into from
Sep 19, 2023

Conversation

jmlord
Copy link
Contributor

@jmlord jmlord commented Sep 15, 2023

Can now edit input and output labels and descriptions in right pane of pipeline editor.
Labels dissalow line breaks (allowed in descriptions)

@jmlord jmlord requested a review from glaroc September 15, 2023 18:32
@jmlord jmlord changed the title Edit pipeine io Edit pipeline io Sep 19, 2023
Copy link
Contributor

@frousseu frousseu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe say that the editing of the descriptions and labels needs to be copied and then pasted in the pipeline .json to take effect? Otherwise it is not super obvious.

@jmlord
Copy link
Contributor Author

jmlord commented Sep 19, 2023

Maybe say that the editing of the descriptions and labels needs to be copied and then pasted in the pipeline .json to take effect? Otherwise it is not super obvious.

We already had this in the local setup section:

When modifying pipelines in the /pipelines folder, servers do not need to be restarted:

  • In the pipeline editor, click save, paste the file to your file in the pipeline folder and run it from the "pipeline run" page.
  • When adding or renaming pipelines, refresh the browser page.

I added this in the IO part:

Once edited, make sure to save your work before leaving the page.

Then clicking save pops up the alert telling you to copy/paste it and use git.

@jmlord jmlord merged commit b357740 into main Sep 19, 2023
2 checks passed
@jmlord jmlord deleted the edit-pipeine-io branch September 19, 2023 20:41
biorey pushed a commit to PEM-Humboldt/biab-2.0 that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants