Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run in background #129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't run in background #129

wants to merge 1 commit into from

Conversation

glaroc
Copy link
Contributor

@glaroc glaroc commented Sep 18, 2024

No description provided.

@glaroc glaroc requested a review from jmlord September 18, 2024 14:35
@jmlord
Copy link
Contributor

jmlord commented Sep 18, 2024

Notes on this:

  • It will print FAILED when terminating the process. The script must differentiate SIGINT from command failure.
  • Very clear documentation to explain to users not used to terminals how to stop this and not feel "trapped".
  • Test that it does work in all environments (linux, mac, windows (WSL & git bash))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants