building hA2025 model #459
Conversation
nusense
left a comment
nusense
left a comment
There was a problem hiding this comment.
This is a very incomplete look at a few of the files with some feedback comments
| @@ -0,0 +1,26 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
This seems to be a private, specific script and I question it's general use and thus the addition to the repo
| @@ -0,0 +1,1631 @@ | |||
| //____________________________________________________________________________ | |||
| /* | |||
| Copyright (c) 2003-2024, The GENIE Collaboration | |||
There was a problem hiding this comment.
Copyrights everywhere should be brought up-to-date to include 2025
| For the full text of the license visit http://copyright.genie-mc.org | ||
|
|
||
|
|
||
| Author: Steve Dytman <dytman+@pitt.edu>, Pittsburgh Univ. |
There was a problem hiding this comment.
Is this author list accurate? The date at the end suggests that this is a from a copy of another file.
|
|
||
| For the class documentation see the corresponding header file. | ||
|
|
||
| Important revisions after version 2.0.0 : |
There was a problem hiding this comment.
Are these revision comments accurate for this file?
I suspect that the boilerplate comments for all the files in this PR need to be reviewed for relevancy and completeness.
|
this is superceded by new pull request based on master. |
3 participants
adding a new class for hA2025 with the corresponding cross section data