Skip to content

Commit

Permalink
Fix svg checker double posting comment (devicons#660)
Browse files Browse the repository at this point in the history
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
  • Loading branch information
Thomas-Boi and amacado authored May 31, 2021
1 parent 6b29801 commit 6aff70e
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions .github/workflows/post_check_svgs_comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,22 +35,6 @@ jobs:
with:
path: ./svg_err_messages/svg_err_messages.txt

# - name: Comment on the PR about the result - Success
# uses: jungwinter/comment@v1 # let us comment on a specific PR
# if: success() && steps.err_message_reader.outputs.content == '1'
# env:
# MESSAGE: |
# Hi!
# I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

# Have a nice day,
# SVG-Checker Bot :grin:
# with:
# type: create
# issue_number: ${{ steps.pr_num_reader.outputs.content }}
# token: ${{ secrets.GITHUB_TOKEN }}
# body: ${{ env.MESSAGE }}

- name: Comment on the PR about the result - SVG Error
uses: jungwinter/comment@v1 # let us comment on a specific PR
if: success() && (steps.err_message_reader.outputs.content != '0' && steps.err_message_reader.outputs.content != '1')
Expand Down Expand Up @@ -79,11 +63,6 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
body: ${{ format(env.MESSAGE, steps.err_message_reader.outputs.content) }}

# if we posted error messages before, we fail this entire workflow
- name: Fail workflow is there is an error.
uses: cutenode/action-always-fail@v1.0.1
if: success() && (steps.err_message_reader.outputs.content != '0' && steps.err_message_reader.outputs.content != '1')

- name: Comment on the PR about the result - Failure
uses: jungwinter/comment@v1 # let us comment on a specific PR
if: failure()
Expand Down

0 comments on commit 6aff70e

Please sign in to comment.