Repository navigation
Conversation
Fixes POL-311. `GET /v1/boxes/{id}` (and its self-hosted-server
twin) never included network metadata, so `BoxResponse::to_box_info()`
hardcoded `network: None` — the SDK's `get_info()`/`list_info()`
had no way to tell whether a box is publicly reachable.
Wire the field through: apps/api's boxToBoxResponse now serializes
the already-tracked box.public/networkBlockAll/networkAllowList as
network.{inbound,outbound}; core's BoxResponse deserializes it into
BoxInfo.network using the NetworkInfo shape from boxlite-ai#1206 (POL-207)
instead of adding a redundant public: bool. The self-hosted serve
command gets the same field for parity, since it already carries
this data locally.
Owner
Author
|
Superseded by boxlite-ai#1364 (opened against upstream main instead of the fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes POL-311. Stacked on boxlite-ai#1206 (POL-207) — based here on
G4614/boxlite because boxlite-ai#1206's branch isn't pushed to boxlite-ai/boxlite. Once
boxlite-ai#1206 merges to main, this should be retargeted to boxlite-ai/boxlite:main.
Before
Self-hosted
boxlite servehad the same gap: it always computesBoxInfo.networklocally but never put it on the wire (
BoxResponseincommands/serve/types.rshad no
networkfield).After
Reuses the
NetworkInfo{ outbound, inbound }shape from boxlite-ai#1206 (POL-207) insteadof adding a separate
public: bool—inbound.mode == Enabledis the visibilitysignal, so there's one field to keep in sync instead of two.
Test plan
cargo test -p boxlite --lib --features rest rest::types::tests— 19/19 pass,including new
test_box_response_to_box_info_carries_network_visibilityto_box_info()'s new line, new test failed at"network metadata should survive conversion"; restored, passes
cargo check -p boxlite --features rest -p boxlite-cli --tests— cleanyarn nx test api— 566 passed, 72 skipped, 0 failed (full api suite,including 4 new cases in
box-to-box.mapper.spec.ts)🤖 Generated with Claude Code