Repository navigation
Conversation
…ed REST Adds the CLI --privileged flag and the self-hosted REST/OpenAPI surface for the AdvancedBoxOptions.privileged mechanism feat/dind-privileged-plumbing (boxlite-ai#646) adds. Pure consumer: no new mechanism, just wiring a caller onto the Rust API's set_privileged/AdvancedBoxOptions.privileged that already exists on this branch. Before: --privileged / the REST body field don't exist; only the Rust API (AdvancedBoxOptions.privileged, set_privileged) can request privileged mode. After: cli.rs/commands::create::run parse --privileged and call set_privileged(true) -> AdvancedBoxOptions.privileged rest/types.rs deserializes the same field from the REST request body openapi/box.openapi.yaml documents both the request field and the capabilities.privileged_enabled response flag
Owner
Author
|
Reopening as a proper cross-repo PR against boxlite-ai/boxlite so it's visible to upstream reviewers, matching boxlite-ai#646/boxlite-ai#1156's own shape. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the CLI
--privilegedflag and self-hosted REST/OpenAPI exposure for theAdvancedBoxOptions.privilegedmechanismfeat/dind-privileged-plumbing(#646) adds — split out the same way#1156split the control-plane/runner/SDK surfaces out of#646.Stacked on
feat/dind-privileged-plumbing, notmain: this branch needsAdvancedBoxOptions.privileged/set_privilegedto exist to compile, so it can't merge before#646does. Once#646merges tomain, retarget this PR's base tomain.Test plan:
make clippy— clean, including cross-compiled guest cratemake test:unit:rust— 1006 + 49 passedmake fmt:check:rust— clean