Skip to content

feat: ssh key retention #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: denis-coric/ssh-flow
Choose a base branch
from

Conversation

dcoric
Copy link
Collaborator

@dcoric dcoric commented Jun 16, 2025

This pull request introduces a comprehensive SSH key retention feature for Git Proxy, enabling secure storage and reuse of user SSH keys during the approval process. This eliminates the need for re-authentication after push approval, while maintaining robust security measures such as encryption, expiration, and cleanup. The changes span documentation updates, new components, database schema modifications, and enhancements to existing processing flows.

Documentation and Architecture Updates:

  • docs/SSH_KEY_RETENTION.md: Added detailed documentation covering the problem statement, solution architecture, security features, implementation details, configuration, and future enhancements for the SSH key retention feature.

Core Feature Implementation:

Database and Action Enhancements:

  • src/db/types.ts: Extended the Push type to include fields for encrypted SSH keys, expiration timestamps, and protocol information.
  • src/proxy/actions/Action.ts: Updated the Action class to support SSH user information, including public key details and protocol-specific data.

Processing Flow Updates:

Storing user key for post-approval process
@dcoric dcoric self-assigned this Jun 16, 2025
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant